Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Prod Only - the workspace feature flag does not hide the button on Prod but works on Staging #884

Open
humansinstitute opened this issue Jan 7, 2025 · 9 comments
Assignees
Labels
Bounties bug Something isn't working

Comments

@humansinstitute
Copy link
Collaborator

humansinstitute commented Jan 7, 2025

Related to: #877

@tobi-bams can you have a look at this with @aliraza556

Not sure why but this change should be deployed, but when testing on Staging it works and when I do the same setup on prod, it fails.

https://www.loom.com/share/bc7cd2cea4fd4874b6f7f5ee53b7bbe4

@humansinstitute humansinstitute added the bug Something isn't working label Jan 7, 2025
@humansinstitute
Copy link
Collaborator Author

@aliraza556 @tobi-bams

Second issues with this is if you flick the "swtich" to enable / disable.It remove the name of the feature flag on update (likely the update end point only updates the fields sent ??)

Then the feature flag can be deleted but we're just kind of stuck at this point.

https://www.loom.com/share/5fe187352aee486eb4f6b754ce5ba8d3

@humansinstitute
Copy link
Collaborator Author

@aliraza556 if you're able to figure out and resolve will pay on PR.

@aliraza556
Copy link
Contributor

aliraza556 commented Jan 7, 2025

@tobi-bams, @humansinstitute #877 Release remaining

image

@aliraza556
Copy link
Contributor

@aliraza556 if you're able to figure out and resolve will pay on PR.

@humansinstitute Sure

@aliraza556
Copy link
Contributor

Related to: #877

@tobi-bams can you have a look at this with @aliraza556

Not sure why but this change should be deployed, but when testing on Staging it works and when I do the same setup on prod, it fails.

https://www.loom.com/share/bc7cd2cea4fd4874b6f7f5ee53b7bbe4

@humansinstitute #877 is not released; this is why the functionality is not visible in production.

@humansinstitute
Copy link
Collaborator Author

ahh ok. @tobi-bams this must have been a few minutes outside of our go live window when you created the image.

@aliraza556 can you propose a fix for fixing the switcher which breaks the feature flag name and I'll create a bounty in the morning

@aliraza556
Copy link
Contributor

ahh ok. @tobi-bams this must have been a few minutes outside of our go live window when you created the image.

@aliraza556 can you propose a fix for fixing the switcher which breaks the feature flag name and I'll create a bounty in the morning

@humansinstitute Sure

@tobi-bams
Copy link
Collaborator

ahh ok. @tobi-bams this must have been a few minutes outside of our go live window when you created the image.

@aliraza556 can you propose a fix for fixing the switcher which breaks the feature flag name and I'll create a bounty in the morning

Oh make sense!!...

@humansinstitute should I deploy again??

@humansinstitute
Copy link
Collaborator Author

@tobi-bams if you didn't last night then lets do it when you come online today, there's quite a few UI tweaks going through each day at the moment.

Is it simple enough to also pull a list of which PRs are in a specific release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounties bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants