Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equinox woes: declared class attributes #3

Open
dlwh opened this issue Apr 10, 2023 · 0 comments
Open

Equinox woes: declared class attributes #3

dlwh opened this issue Apr 10, 2023 · 0 comments

Comments

@dlwh
Copy link
Member

dlwh commented Apr 10, 2023

from JohnH:

Why can’t I set attributes that weren’t declared as class attributes? I probably should have realized this but at this point am just going through and adding them…

This is a constraint in equinox but actually pretty unnecessary, except for declaring static fields. We should maybe raise to Patrick or just fork away from equinox... It wouldn't be hard to make our own Module and do our own thing. (I also think he treats the precise behavior of tree_flatten in modules as internal behavior, but we rely on it...)

@dlwh dlwh transferred this issue from stanford-crfm/levanter Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant