Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract storage page is still referring to the old cairo syntax #883

Closed
glihm opened this issue Oct 7, 2023 · 2 comments
Closed

Contract storage page is still referring to the old cairo syntax #883

glihm opened this issue Oct 7, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@glihm
Copy link
Contributor

glihm commented Oct 7, 2023

Describe the bug
Smart contract storage page is still using outdated cairo syntax and decorators.
(Not sure if it can be considered as a bug or a feature, I do apologize if bug is not appropriate).

To Reproduce

  1. Go to storage page.

Expected behavior
Updated content for the new syntax.

Desktop (please complete the following information):
Any version.

Additional context
I would love to try submitting a PR to edit this content if you agree.

@glihm glihm added the bug Something isn't working label Oct 7, 2023
@glihm
Copy link
Contributor Author

glihm commented Oct 7, 2023

Quick question also, with components, is the address still computed the same way? And we do need to take care about not having several components with the same variables names in the storage?
I'm diving in the compiler code to check about this, any insights would be very helpful. Thank you!

@ArielElp
Copy link
Collaborator

ArielElp commented Jan 7, 2024

I think that the page was updated since the time of the issue. In any case, with v0 components, you cannot have the same storage var name in two different components, and compilation will fail. The vision there is to have the storage/events of each component lie in their own space (e.g. via an offset determined at the contract), or, more generally, give the contract some convenient way of determining the layout of the different components in storage.

@ArielElp ArielElp closed this as completed Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants