Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*Seeking Contribution* PRs from forks are not generating preview builds. #938

Closed
stoobie opened this issue Nov 16, 2023 · 6 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@stoobie
Copy link
Collaborator

stoobie commented Nov 16, 2023

Describe the bug

When a PR originates from a forked repo, it does not generate an HTML preview to enable reviewing and testing the PR in a browser prior to merging.

The issue becomes visible when the runner runs the Commit changes step in the pull_requent.yml workflow.

To Reproduce
Steps to reproduce the behavior:

  1. Fork (and optionally clone) the starknet-docs repo.
  2. Create a new branch and make a small change in an .adoc file.
  3. Push the new branch and create a new PR.

Expected behavior
You should see this in Conversaton tab of the PR
image

You should also see a link like this one (with the correct PR-number):
image

@stoobie stoobie added the bug Something isn't working label Nov 16, 2023
@stoobie
Copy link
Collaborator Author

stoobie commented Dec 11, 2023

So far I've been unable to fix this issue. If you want to take a look and try to fix it, your contribution will be very much appreciated.

@stoobie stoobie changed the title PRs from contributors are not generating preview builds. Contribution wanted: PRs from forks are not generating preview builds. Dec 11, 2023
@stoobie stoobie changed the title Contribution wanted: PRs from forks are not generating preview builds. *Seeking Contribution* PRs from forks are not generating preview builds. Jan 2, 2024
@stoobie stoobie added the Seeking contribution Good issue for an external contribution label Jan 2, 2024
@stoobie stoobie closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2024
@stoobie
Copy link
Collaborator Author

stoobie commented Jan 17, 2024

This is a duplicate of #1043

@stoobie stoobie reopened this Apr 1, 2024
@stoobie
Copy link
Collaborator Author

stoobie commented Apr 1, 2024

Unfortunately, #1182 was required to revert the PRs #1097 and #1152 of the pull_request_target event.

So we are back to where we started with this one.

@xiaolou86
Copy link
Contributor

I am very sorry. Let other people come to resolve it firstly.

@xiaolou86
Copy link
Contributor

Generally speaking, the pull_request_target event is more security than pull_request event, maybe there is something wrong with the token.

@stoobie stoobie removed the Seeking contribution Good issue for an external contribution label Apr 30, 2024
@stoobie stoobie mentioned this issue May 7, 2024
2 tasks
@stoobie
Copy link
Collaborator Author

stoobie commented May 7, 2024

This is closed by #1250.

@stoobie stoobie closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants