Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Performer alias(es) in Auto-Tag #2507

Open
ThisIsDF opened this issue Apr 13, 2022 · 5 comments · Fixed by #3113
Open

[Feature] Performer alias(es) in Auto-Tag #2507

ThisIsDF opened this issue Apr 13, 2022 · 5 comments · Fixed by #3113

Comments

@ThisIsDF
Copy link

Is your feature request related to a problem? Please describe.
When Auto-Tagging Performers in Scenes, the system currently only uses the Performer Name field, and doesn't take the aliases into account.

Describe the solution you'd like
When Auto-Tagging, use the Performer name and aliases when checking the Scene filename. This could be optional, by adding a flag in the settings "Use aliases in Auto-Tag task"

Describe alternatives you've considered
Changing the Performer name to the alias used in the Scene filename(s), and using the Auto-Tag job / task works correctly. But if the Performer has multiple aliases which are all uses in Scene filenames, you would have to cycle through all aliases and put them in the name field.

And thanks for this great application, keep up the fantastic work!

@QxxxGit
Copy link

QxxxGit commented Apr 15, 2022

In addition to a setting to look for aliases in the auto-tagger, I think there should be a flag for each individual performer. This option would default to false (do not auto-tag the aliases for this performer). Otherwise, you run into potential conflicts like similar names.

@Sureiya
Copy link

Sureiya commented Apr 17, 2022

There should be a way to do this extremely efficiently using semantic relationships to constrain and order the potential results.

@echo6ix
Copy link
Contributor

echo6ix commented Jun 18, 2022

There should be a way to do this extremely efficiently using semantic relationships to constrain and order the potential results.

Like this? #422

@scruffynerf
Copy link

we added individual 'ignore auto tag'

but alias matching would be a disaster:

summary from discord discussion:
Q: the Auto Tag feature in settings won't set the performer if the folder name the files are in is an alias of the performer. It will only auto tag the performer if the folder name is an exact match to the performer's name field. I would expect it to extend it to the aliases fields as well.

Scruffy: Nope, no aliases. Aliases are not unique. You can have multiple performers with the same alias.
Jane Doe and Jane Fonda can both have Jane as an alias... And as a result of your "suggestion", both would end up tagged on all folders containing Jane (even if the folders were named Jane Doe and Jane Fonda and Jane Smith)
We should correct your mistaken expectation by using better text to say that explicitly, so you don't expect it to work on Aliases.

Q: Wouldn't a solution be for it to behave like that, except when there are conflicts like these?

Scruffy: It has no way of knowing what's a "conflict" and what's a correct match. Even ONE Jane alias would mistag everything. In fact, my hard rule of thumb is ALL one word performers are marked as Ignore Auto Tag, because it always screws up things with the occasional exception for fairly unique names like LaSirena69.

@Liembert
Copy link

Liembert commented Dec 12, 2023

How about this, A checkmark next to aliases in the profile page for "include in auto tag" that way, it's a white list, and we specifically choose which ones to use, so we just check off the aliases we know are unique in our own collection? And people who don't know about the change won't get their tagging messed up since it's something you have to proactively enable.,

or even more foolproof, a box to check off an alias to check for duplicates as if making a new entry, And then block off new entries / aliases matching that until its unchecked. If incorrect tagging is a concern I don't see why you can't put the same safeguards for the normal name to the aliases that people want to auto tag.

I mean one of the primary functions of stash is organization/tagging, and not being able to automatically tag aliases limits that function. I literally found this issue because I was searching for how to auto tag alias. After checking for scenes with no performers tagged, and found a whole bunch in my DB where the performer hand an entry, but the file name had an alias or a different spelling and so it wasn't tagged, I was like fuck. I'm not gonna do this by hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants