From 05ca2d3baf9b4fe4030f31e73cffb9265a18cbac Mon Sep 17 00:00:00 2001 From: Amund Tenstad Date: Wed, 5 Feb 2025 13:06:55 +0100 Subject: [PATCH] refactor: ptr.Equal --- .../groupqualityofservicelimits.go | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/internal/controller/groupqualityofservicelimits/groupqualityofservicelimits.go b/internal/controller/groupqualityofservicelimits/groupqualityofservicelimits.go index 8da662d6..4ae0375d 100644 --- a/internal/controller/groupqualityofservicelimits/groupqualityofservicelimits.go +++ b/internal/controller/groupqualityofservicelimits/groupqualityofservicelimits.go @@ -309,13 +309,9 @@ func toCloudianLimits(limits *v1alpha1.QualityOfServiceLimits) (cloudian.Quality } func limitsEqual(a cloudian.QualityOfServiceLimits, b cloudian.QualityOfServiceLimits) bool { - eq := func(a *int64, b *int64) bool { - return (a == b) || (a != nil && b != nil && *a == *b) - } - - return eq(a.InboundKiBsPerMin, b.InboundKiBsPerMin) && - eq(a.OutboundKiBsPerMin, b.OutboundKiBsPerMin) && - eq(a.RequestsPerMin, b.RequestsPerMin) && - eq(a.StorageQuotaCount, b.StorageQuotaCount) && - eq(a.StorageQuotaKiBs, b.StorageQuotaKiBs) + return ptr.Equal(a.InboundKiBsPerMin, b.InboundKiBsPerMin) && + ptr.Equal(a.OutboundKiBsPerMin, b.OutboundKiBsPerMin) && + ptr.Equal(a.RequestsPerMin, b.RequestsPerMin) && + ptr.Equal(a.StorageQuotaCount, b.StorageQuotaCount) && + ptr.Equal(a.StorageQuotaKiBs, b.StorageQuotaKiBs) }