Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump outdated Go dependencies #69

Merged
merged 1 commit into from
Dec 22, 2024
Merged

fix: bump outdated Go dependencies #69

merged 1 commit into from
Dec 22, 2024

Conversation

erikgb
Copy link
Member

@erikgb erikgb commented Dec 21, 2024

This bumps outdated Go dependencies. It seems like Renovate is non-working in this project, maybe because it is currently a private project.

@erikgb erikgb requested review from mariatsji and tenstad December 21, 2024 15:58
@erikgb erikgb self-assigned this Dec 21, 2024
@erikgb erikgb enabled auto-merge (squash) December 21, 2024 16:00
@erikgb erikgb merged commit 6a93f41 into main Dec 22, 2024
5 checks passed
@mikaelol
Copy link
Contributor

@erikgb Renovate is working, this was an open pull request before you merged this PR: #54

I also notice that the branch for this pull request is not deleted, should we turn on auto-delete for branches of merged PRs?

@erikgb
Copy link
Member Author

erikgb commented Dec 26, 2024

For some reason, Renovate is not running go mod tidy. That's what I meant with "not working".

@erikgb
Copy link
Member Author

erikgb commented Dec 26, 2024

Agree to auto-delete branches, but hope we can start working in forks soon.

@mikaelol
Copy link
Contributor

For some reason, Renovate is not running go mod tidy. That's what I meant with "not working".

Hm, seems like that is not happening except for major upgrades, from the doc of option enabling go mod tidy:

Run go mod tidy after Go module updates. This is implicitly enabled for major module updates when gomodUpdateImportPaths is enabled.

Source: https://docs.renovatebot.com/configuration-options/#postupdateoptions

@erikgb
Copy link
Member Author

erikgb commented Dec 26, 2024

But that's wrong and will make CI fail. 😊 Why?

@statnett-bot statnett-bot bot mentioned this pull request Jan 2, 2025
@erikgb erikgb deleted the bump-deps branch January 2, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants