From ec559546f25f2c2cdb73519899ca5358b68f48a3 Mon Sep 17 00:00:00 2001 From: acolytec3 <17355484+acolytec3@users.noreply.github.com> Date: Sun, 3 Nov 2019 06:14:33 -0500 Subject: [PATCH] Add tests for ENS in EIP681 and linting fixes --- src/status_im/ethereum/eip681.cljs | 10 +++++----- src/status_im/wallet/choose_recipient/core.cljs | 1 - test/cljs/status_im/test/ethereum/eip681.cljs | 3 +++ 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/status_im/ethereum/eip681.cljs b/src/status_im/ethereum/eip681.cljs index 9baa54f348d1..22beba527a06 100644 --- a/src/status_im/ethereum/eip681.cljs +++ b/src/status_im/ethereum/eip681.cljs @@ -58,13 +58,13 @@ (let [pay-address (string/replace-first raw-address "pay-" "")] (or (ens/is-valid-eth-name? pay-address) (ethereum/address? pay-address))))) - (let [address (if (string/starts-with? raw-address "pay-") - (string/replace-first raw-address "pay-" "") + (let [address (if (string/starts-with? raw-address "pay-") + (string/replace-first raw-address "pay-" "") raw-address)] (when-let [arguments (parse-arguments function-name query)] - (merge {:address address - :chain-id (if chain-id - (js/parseInt chain-id) + (merge {:address address + :chain-id (if chain-id + (js/parseInt chain-id) (ethereum/chain-keyword->chain-id :mainnet))} arguments))))))))) diff --git a/src/status_im/wallet/choose_recipient/core.cljs b/src/status_im/wallet/choose_recipient/core.cljs index 0f79459387ea..5620e7465920 100644 --- a/src/status_im/wallet/choose_recipient/core.cljs +++ b/src/status_im/wallet/choose_recipient/core.cljs @@ -90,7 +90,6 @@ {:ui/show-error (i18n/label :t/wallet-invalid-address-checksum {:data recipient})})) {:ui/show-error (i18n/label :t/wallet-invalid-address {:data recipient})})))) - (fx/defn fill-request-from-url {:events [:wallet/fill-request-from-url]} [{{:networks/keys [current-network] :wallet/keys [all-tokens] :as db} :db} data origin] diff --git a/test/cljs/status_im/test/ethereum/eip681.cljs b/test/cljs/status_im/test/ethereum/eip681.cljs index 210325123733..6736a5b23b64 100644 --- a/test/cljs/status_im/test/ethereum/eip681.cljs +++ b/test/cljs/status_im/test/ethereum/eip681.cljs @@ -11,6 +11,9 @@ (is (= nil (eip681/parse-uri "ethereum:?value=1"))) (is (= nil (eip681/parse-uri "bitcoin:0x1234"))) (is (= nil (eip681/parse-uri "ethereum:0x1234"))) + (is (= nil (eip681/parse-uri "ethereum:gimme.eth?value=1e18"))) + (is (= {:address "gimme.eth" :value "1e18" :chain-id 1} (eip681/parse-uri "ethereum:pay-gimme.eth?value=1e18"))) + (is (= {:address "0x89205a3a3b2a69de6dbf7f01ed13b2108b2c43e7" :value "1e18" :chain-id 1} (eip681/parse-uri "ethereum:pay-0x89205a3a3b2a69de6dbf7f01ed13b2108b2c43e7?value=1e18"))) (is (= {:address "0x89205a3a3b2a69de6dbf7f01ed13b2108b2c43e7" :chain-id 1} (eip681/parse-uri "ethereum:0x89205a3a3b2a69de6dbf7f01ed13b2108b2c43e7"))) (is (= {:address "0x89205a3a3b2a69de6dbf7f01ed13b2108b2c43e7" :value "1" :chain-id 1} (eip681/parse-uri "ethereum:0x89205a3a3b2a69de6dbf7f01ed13b2108b2c43e7?value=1"))) (is (= {:address "0x89205a3a3b2a69de6dbf7f01ed13b2108b2c43e7", :chain-id 1} (eip681/parse-uri "ethereum:0x89205a3a3b2a69de6dbf7f01ed13b2108b2c43e7?unknown=1")))