Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some assets (ADX in particular case) are not shown on wallet when they are received to multiaccount until manual adding #10786

Closed
churik opened this issue Jun 9, 2020 · 11 comments

Comments

@churik
Copy link
Member

churik commented Jun 9, 2020

Bug Report

Problem

When receiving some assets to wallet, sometimes they are not shown until manual enabling them in assets (transaction is confirmed) and reopening app.
Reproducibility 100% with ADX.

Expected behavior

ADX amount is shown

Actual behavior

ADX is not shown, amount is displayed only after (1) enabling ADX manually in assets and (2) restarting app
Video is here

Reproduction

  • Open Status
  • Create empty multiaccount A
  • Send some ADX from another multiaccount to multiaccount A
  • Multiaccount A: wait until transaction is confirmed

Additional Information

  • Status version: release 1.4
  • Operating System: Android, iOS

Logs

status_logs-4.zip

@churik churik added the bug label Jun 9, 2020
@churik churik changed the title Some assets (ADX in particular case) Some assets (ADX in particular case) are not shown on wallet when they are received to multiaccount until manual adding Jun 9, 2020
@churik
Copy link
Member Author

churik commented Jun 16, 2020

Also confirmed with USDC

@hesterbruikman
Copy link
Contributor

Wondering if this is a bug or designed behavior. @churik do you know if other assets are added upon being received?

If I recall correctly we only show SNT and Ether by default and don't do path scanning on importing keys (or on other occasions) to see if you have other assets. Don't know if there's a difference for the situation of receiving assets to 'existing' accounts.

cc @johnlea-quiup

@churik
Copy link
Member Author

churik commented Jun 16, 2020

@hesterbruikman
it is an issue for sure, tried with AST and BLT - and they are shown after 3d confirmation on wallet without enabling them manually
photo_2020-06-16 16 21 30

@churik
Copy link
Member Author

churik commented Jul 2, 2020

Confirmed with AMB

@hesterbruikman
Copy link
Contributor

Sounds like two problems, we might address separately

  1. having to restart after manually enabling certain assets
  2. having to add assets manually in the first place

I'd treat this GH issue as a focus on 1. For the second, I'll create a new issue in the Import accounts epic to enable scanning for assets on accounts. Once that's introduced in onboarding, I think it'll be more straightforward to add a way to call this method from within the wallet

@hesterbruikman
Copy link
Contributor

From the video, it seems like the app could check if a received token is already checked in Managed assets, if not, suggest the user to add it. This depends on whether adding the asset requires connecting to collect token address and icon. If no IP address is exposed when collecting this information it could potentially be done automatically on behalf of the user

@hesterbruikman
Copy link
Contributor

User report

The wallet I'm watching from the status app doesn't show my balance of LRC. I've checked the box in manage assets multiple times even after phone restarts. I'm being told it must be a bug so I'm just giving you guys a heads up. Thanks.

Confirmed by another user

Reproducing in 1.5

Android 10 Samsung Galaxy s10e
LRC appears instantly after adding through manage assets

@churik Any recommendation on where to get ADX? Uniswap and Kyber don't seem to offer. 1inch does, but it keeps reloading i Status (will add here)

@churik
Copy link
Member Author

churik commented Aug 4, 2020

@hesterbruikman I can send you some, give me your address in dm

@churik
Copy link
Member Author

churik commented Aug 4, 2020

Couldn't reproduce with AMB, ADX on Android 10 and Android 9 - issue is not reproducible anymore on 1.5

@churik churik closed this as completed Aug 4, 2020
@Serhy
Copy link
Contributor

Serhy commented Sep 24, 2020

Reopening this issue because it reproduced with UNI in my case of Android 8.1.

On AccountB - no UNI selected in Wallet.
AccountA sent to AccountB '10 UNI'. Result: no token appeared in main Wallet screen.
AccountB enables UNI from Assets view. It shows 0.
AccountB exchanges 5 UNI into ETH in Uniswap and correct amount is picked up in DApp.
AccountB after exchange successfully made and ETH amount updated in Wallet -> UNI amount keep with '0'
AccountB re-opens Status and UNI reflects correctly 5 tokens.

@churik
Copy link
Member Author

churik commented Oct 21, 2020

Closed with "Scan tokens" button in wallet

@churik churik closed this as completed Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants