Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Enable biometric' screen is not included to 'Sign in with QR' flow #15643

Closed
churik opened this issue Apr 13, 2023 · 5 comments · Fixed by #17627
Closed

'Enable biometric' screen is not included to 'Sign in with QR' flow #15643

churik opened this issue Apr 13, 2023 · 5 comments · Fixed by #17627
Assignees
@jo-mut
Milestone
1.26.0 - Alpha

Comments

@churik
Copy link
Member

churik commented Apr 13, 2023

Bug Report

Problem

There is no 'Enable biometric' screen included in o 'Sign in with QR' flow, which is the part of design

Expected behavior

can see 'Eanble biometric' before syncing data

Actual behavior

no screen

Reproduction

  1. Open Status
  2. Finish flow Sign in > scan QR

Additional Information

  • Status version: nightly 13/04/23
  • Operating System: Android, iOS
@churik churik added the bug label Apr 13, 2023
@churik churik added this to the 1.23.0 milestone Apr 13, 2023
@ajayesivan ajayesivan self-assigned this Apr 19, 2023
@ajayesivan
Copy link
Contributor

Sync from device flow in the Figma design doesn't seem to have Enable biometric screen. Where should I add it in the flow?

@pedro-et @churik

@ajayesivan
Copy link
Contributor

Updated Design: https://www.figma.com/file/o4qG1bnFyuyFOvHQVGgeFY/Onboarding-for-Mobile?node-id=6953-332528&t=VAS9IiO75lFGpqKV-4

@churik churik modified the milestones: 1.24.0 - Alpha, 1.25.0 - Alpha Jul 4, 2023
@ajayesivan ajayesivan removed their assignment Sep 7, 2023
@ajayesivan
Copy link
Contributor

I'm unassigning this issue as I am currently not working on it. Please feel free to pick it up. If no one takes it, I will reassign it to myself when I am able to actively work on it again.

@clauxx clauxx self-assigned this Sep 8, 2023
@clauxx clauxx removed their assignment Sep 16, 2023
@jo-mut jo-mut self-assigned this Sep 25, 2023
@jo-mut jo-mut mentioned this issue Oct 12, 2023
Merged
@cammellos
Copy link
Contributor

@jo-mut could you give us an update please?

@jo-mut
Copy link
Contributor

jo-mut commented Oct 25, 2023

@cammellos this is ready. Am testing it to make sure no further issues

@ilmotta ilmotta removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jo-mut jo-mut

Labels
None yet
Projects
None yet
Milestone
1.26.0 - Alpha
Development

Successfully merging a pull request may close this issue.

add navigate biometric screen after sign-in by syncing status-im/status-mobile
6 participants
@ilmotta @cammellos @churik @ajayesivan @clauxx @jo-mut