-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make part of next color picker visible in color pickers scroll bar #17443
Comments
Hey @pavloburykh |
Hi @ibrkhalil iPhone X: Samsung Galaxy A52: |
Thinking more about implementing it, I think it's not possible to make the same look on all devices while having each circle the same width because devices have different widths and the number of visible circles and how they look is very much dependant on device width. |
@ibrkhalil we can make the margins dynamic |
Let me give it another attempt with dynamic margins and report back. |
@ibrkhalil A circle's total size is its width plus its margin. So making the width dynamic or the margin dynamic should give the same result |
As mentioned here we shouldn't change the circle size but margins between circles should be flexible :) |
Ookay, Let me give it a shot. |
@ibrkhalil could you give us an update on this one please? |
I mentioned @pavloburykh on the PR, Telling him that I did the dynamic margin and it's ready for a rereview |
Thank you. I will review today and provide feedback in the PR. |
Followup of #17405 cc @OmarBasem
Discussed here
Currently part of next color picker is not visible wich makes it not obvious for user that color pickers are scrollable.
We should make part of next color picker visible as it is shown on the designs
Expected result:
https://www.figma.com/file/o4qG1bnFyuyFOvHQVGgeFY/Onboarding-for-Mobile?type=design&node-id=2241-250931&mode=design
Actual result:
Additional Information
The text was updated successfully, but these errors were encountered: