Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI issues in new Wallet on Transactions History tab #1801

Closed
annadanchenko opened this issue Sep 9, 2017 · 4 comments · Fixed by #1807
Closed

UI issues in new Wallet on Transactions History tab #1801

annadanchenko opened this issue Sep 9, 2017 · 4 comments · Fixed by #1807
Assignees

Comments

@annadanchenko
Copy link

annadanchenko commented Sep 9, 2017

Issues:

  1. Grey colour of the icons for incoming/outgoing transactions. Expected: as in design: green for incoming, blue for outgoing. Both Android and iOS.
  2. No "phone icons" on iOS (carrier, time, battery percentage..)
  3. Tab titles "Unsigned/History" are too small on iOS
  4. Postponed/Pending sections are always empty now - remove them or check with design team how to show they are empty... Now there are 2 words on the screen where it's not clear they are Section titles. both Android and iOS
  5. If pull down list of the transaction then no loading indicator is shown, on iOS
  6. ">" icon on the right side of transaction is of different colour (not light grey but dark grey) and size. both Android and iOS
  7. There is no line under tabs Unsigned/History with blue line under active tab. In the design there is such line. both Android and iOS
  8. There should be no line between header with word Transaction and the rest of the screen

img_0582

Design (iOS):

screen shot 2017-09-09 at 15 50 30

Design (issues 7,8 - should be as in design below 2, 1)
screen shot 2017-09-09 at 15 58 01

real iOS device iPhone 7 plus
develop build 0.9.11d77

@asemiankevich
Copy link
Contributor

Transaction history is cut in the end
image

@annadanchenko
Copy link
Author

annadanchenko commented Sep 11, 2017

Fix for this issue introduced regression bug:
When syncing is in progress then no progress bar for syncing is shown on Chats screen, inside chats and on new Wallet screen
Expected: when syncing is in progress then progress bar (narrow blue line) is shown in Chats, inside Chat (1-1 chat, console, group chat, etc) and Wallet screen

screenshot_20170911-150948

@jeluard
Copy link
Contributor

jeluard commented Sep 11, 2017

Fixed now.

@annadanchenko
Copy link
Author

Regression bug "Syncing progress bar" is fixed and shown now as expected. Issues 1-8 are fixed. @asemiankevich can we close this issue and open a separate one about last item not fully shown? (added as a comment by you).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants