Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect total account balance calculation for default and watch only accounts #18038

Closed
VolodLytvynenko opened this issue Dec 1, 2023 · 2 comments

Comments

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Dec 1, 2023

The fixing of this issue should begin after merging #17879

Reference to #17868 (comment) and to #17821 (comment)

Steps:

Log in as a user with various tokens located on various networks

Actual result:

The account balance calculation appears incorrect for default and for watch-only accounts

image

Expected result:

How the balance is calculated for the same user within Metamask (in fact current user has only on Arbitrium: 0.001 ETH = 2.06 USD). So, the total amount should be 2.06 USD)

image

How the balance is calculated for the same user within Desktop (Take a look, there is bridget USDC = 4.99 usd which is not included into total balance calculation.)
image

Additional info:

Please let me know if you don't have an account with specific tokens, and I can share the seed phrase via private message

@VolodLytvynenko VolodLytvynenko modified the milestone: wallet Dec 1, 2023
@VolodLytvynenko VolodLytvynenko changed the title Incorrect account balance calculation for default and watch only accounts Incorrect total account balance calculation for default and watch only accounts Dec 1, 2023
@OmarBasem OmarBasem assigned OmarBasem and unassigned OmarBasem Dec 18, 2023
@smohamedjavid
Copy link
Member

@VolodLytvynenko - I believe this issue is fixed in #18078. Please help us verify.

@VolodLytvynenko
Copy link
Contributor Author

@VolodLytvynenko - I believe this issue is fixed in #18078. Please help us verify.

hi @smohamedjavid that's correct. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants