Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet - Add Contract test for RPC endpoint - wallet_getAddressDetails #18349

Closed
Tracked by #18587
J-Son89 opened this issue Jan 2, 2024 · 0 comments · Fixed by #19340
Closed
Tracked by #18587

Wallet - Add Contract test for RPC endpoint - wallet_getAddressDetails #18349

J-Son89 opened this issue Jan 2, 2024 · 0 comments · Fixed by #19340
Assignees
@FFFra
Labels
feature feature requests

Comments

@J-Son89
Copy link
Contributor

J-Son89 commented Jan 2, 2024 •
edited
Loading

As part of the wallet flows we want to add contract tests for all Status Go endpoints used by the wallet to help avoid the Go team adding breaking changes going unnoticed on the mobile client.

Add an integration test for the RPC request -
"wallet_getAddressDetails" used in src/status_im/contexts/wallet/events.cljs

For more information/examples on integration tests see this recent pr: #18304
@J-Son89 J-Son89 added the feature feature requests label Jan 2, 2024
@J-Son89 J-Son89 mentioned this issue Jan 22, 2024
Open
17 tasks
@J-Son89 J-Son89 changed the title Wallet - Add Integration test for RPC endpoint - wallet_getAddressDetails Wallet - Add Contract test for RPC endpoint - wallet_getAddressDetails Feb 2, 2024
@FFFra FFFra self-assigned this Mar 20, 2024
@FFFra FFFra moved this from In Progress to Code Review in Do not use - tasks moved to unified Desktop / Mobile Board Mar 20, 2024
@FFFra FFFra mentioned this issue Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FFFra FFFra

Labels
feature feature requests
Projects
Do not use - tasks moved to unified Desktop / Mobile Board
Status: Done
Milestone
No milestone
2 participants
@FFFra @J-Son89