Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet - Add Contract test for RPC endpoint - wallet_getMultiTransactions #18352

Open
Tracked by #18587
J-Son89 opened this issue Jan 2, 2024 · 2 comments
Open
Tracked by #18587

Wallet - Add Contract test for RPC endpoint - wallet_getMultiTransactions #18352

J-Son89 opened this issue Jan 2, 2024 · 2 comments
Labels
feature feature requests wallet-core Issues for mobile wallet team

Comments

@J-Son89
Copy link
Contributor

J-Son89 commented Jan 2, 2024 •
edited
Loading

As part of the wallet flows we want to add contract tests for all Status Go endpoints used by the wallet to help avoid the Go team adding breaking changes going unnoticed on the mobile client.

Add a contract test for the RPC request -
"wallet_getMultiTransactions" used in src/status_im/contexts/wallet/send/events.cljs

For more information/examples on integration tests see this recent pr: #18304
@J-Son89 J-Son89 added the feature feature requests label Jan 2, 2024
@J-Son89 J-Son89 mentioned this issue Jan 22, 2024
Open
17 tasks
@J-Son89 J-Son89 changed the title Wallet - Add Integration test for RPC endpoint - wallet_getMultiTransactions Wallet - Add Contract test for RPC endpoint - wallet_getMultiTransactions Feb 2, 2024
@FFFra
Copy link
Contributor

FFFra commented Mar 20, 2024 •
edited
Loading

@J-Son89 Is this endpoint correct/updated? Cannot find it

@J-Son89
Copy link
Contributor Author

J-Son89 commented Mar 20, 2024

sorry, should be : wallet_createMultiTransaction

@churik churik added wallet-core Issues for mobile wallet team and removed E:Mobile Wallet February labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature feature requests wallet-core Issues for mobile wallet team
Projects
Do not use - tasks moved to unified Desktop / Mobile Board
Status: No status
Status Desktop/Mobile Board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@churik @FFFra @J-Son89