Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications about previous messages should disappear when chat is opened #3487

Closed
lukaszfryc opened this issue Mar 1, 2018 · 6 comments
Closed

Comments

@lukaszfryc
Copy link
Contributor

Description

Type: Bug

Summary: Let's say you have 3 notifications about messages for one chat. When the last notification is clicked which opens the chat. Now, the previous 2 notifications should probably be dismissed. The messages were already seen by the user. Instead, user needs to handle the notifications by herself.

Ideally we should dismiss only notifications of messages that we are sure have been seen by the user. It may happen that there is some old message that user needs to scroll to see. But, the simple solution is to dismiss all related notifications when the chat is opened. I think it's much better than seeing 10 other notifications of a chat that was already seen (the case right now).

Expected behavior

Dismiss notifications when a chat was seen.

Actual behavior

Chat notifications stay even though the messages were seen.

Reproduction

  • User 1: Open Status
  • User 2: Keep Status app in the background
  • User 1: Send 2 messages to User 2
  • User 2: Click on the first message and open the chat with User 1
    -> 2nd notification is still visible.

Additional Information

  • Status version: nightly, March 1
  • Operating System: iOS, Android
@lukaszfryc
Copy link
Contributor Author

It was not fixed by #86 nor #119

@pombeirp are you aware of any swarm that can fix it?

@pedropombeiro
Copy link
Contributor

pedropombeiro commented Apr 12, 2018

@lukaszfryc https://github.com/status-im/ideas/blob/master/ideas/86-push-notif-v2.md is still in draft mode (it was closed in favor of a pull request to add a Markdown file). It should start soon.

GitHub
ideas - Swarm Home. New, completed and in-progress features for Status

@lukaszfryc
Copy link
Contributor Author

Any update on this issue?

@pedropombeiro
Copy link
Contributor

Although this was planned to be fixed in 086-push-notif-v2, there's no reason why work can't start outside that scope. The work that needs to be done is well known (we should send message ID in PN payload (data field), and we should look into dismissing a PN once that message ID appears on screen)

@ghost
Copy link

ghost commented Feb 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale label Feb 27, 2019
@ghost
Copy link

ghost commented Mar 6, 2019

This issue has been automatically closed. Please re-open if this issue is important to you.

@ghost ghost closed this as completed Mar 6, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants