Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX fixes for issue #4791 (Chat design) #4839

Closed
10 tasks
EugeOrtiz opened this issue Jun 19, 2018 · 7 comments
Closed
10 tasks

UI/UX fixes for issue #4791 (Chat design) #4839

EugeOrtiz opened this issue Jun 19, 2018 · 7 comments
Assignees

Comments

@EugeOrtiz
Copy link

EugeOrtiz commented Jun 19, 2018

This is a list of UX/UI improvements for issue #4791

Message area

  • “Sent” label is missing from sent message. (High prio) (added as separate feature Implement display of message statuses  #5018 )
  • Space between 2+ messages from same sender should be 8px, now they are random paddings (11px, 16px, 8px). (Low prio)
  • Space between last message and bottom of message area should be 24px (now is 63px) - (Low prio)
  • Review color of timestamp (time in message), the contrast is too low now and is hard to read. (Low prio)
  • Review color of date (the label in the middle of the area: “Today” "Sep 3"). (Low prio)
  • Message timestamp is not centrally aligned to the message when it is just 1 line. (Low prio)
  • Max width of message bubble for long messages is 340px (is 335px now). (Low prio)

1:1 CHAT SPECIFICS

  • Empty state is missing when talking to somebody for the first time zpl.io/aRqj4dv (Low prio)

PUBLIC CHAT SPECIFICS

  • If same user writes 2+ messages in a row, profile img shouldn’t repeat, it should only be in the latest message of the group. (Mid prio)
  • Empty state is missing when joining a public chat for the first time zpl.io/bAv8OjB (Low prio)
@EugeOrtiz EugeOrtiz changed the title UI/UX improvements for issue #4791 UI/UX fixes for issue #4791 Jun 19, 2018
@EugeOrtiz EugeOrtiz self-assigned this Jun 19, 2018
@churik
Copy link
Member

churik commented Jun 20, 2018

@EugeOrtiz
afaik regarding this particular PR only message area is affected.
Chat list/contacts are the part of PR #4752.
Headers are in #4693.

So I believe there should be left only issues from "Message area" section.
@vkjr can you please highlight what exactly areas were implemented in #4791? (i.e., message area, messages status (like "Sent/not sent"), text input area etc?

@vkjr
Copy link
Contributor

vkjr commented Jun 20, 2018

@churik, @EugeOrtiz, in current PR only UI for message area was improved.
List of contacts and text input left almost untouched.

In general, I would split this issue into few smaller ones, I think that would be easier to implement and test.

@EugeOrtiz
Copy link
Author

@churik @vkjr Done! Will move the rest to specific issues.

@EugeOrtiz EugeOrtiz changed the title UI/UX fixes for issue #4791 UI/UX fixes for issue #4791 (Chat design) Jun 28, 2018
@EugeOrtiz
Copy link
Author

I'm moving this back to non-high-priority column since the high prio item in the list was already covered.

@ghost
Copy link

ghost commented Nov 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale label Nov 13, 2018
@ghost
Copy link

ghost commented Nov 20, 2018

This issue has been automatically closed. Please re-open if this issue is important to you.

@ghost ghost closed this as completed Nov 20, 2018
@churik churik removed the stale label Mar 12, 2019
@churik
Copy link
Member

churik commented Mar 12, 2019

Doesn't make sense in terms of #7551

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants