Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing application window issues #5151

Closed
1 of 5 tasks
churik opened this issue Jul 12, 2018 · 6 comments
Closed
1 of 5 tasks

Resizing application window issues #5151

churik opened this issue Jul 12, 2018 · 6 comments

Comments

@churik
Copy link
Member

churik commented Jul 12, 2018

User Story

As a user, I want to work with application regardless of the app window size.

Description

Type: Bug

Summary: several issues can be replicated when you resize application window.

1) Automatic scroll to latest massage after resize
If initially you are somewhere in the middle of chat history, you automatically pulled back to the latest message after resize
Video is here

2) CPU consumption jumps to 70-100% during resize
Video is here
Log is here

3) Chat headers and messages are displayed in a column in a small-size window and doesn't get back if you resize window to normal size again

Regular size

  • Chat header
    regul
  • Messages
    image

Small size

  • Chat header
    png 2018-07-12 12-52-45
  • Messages
    am_size

Recized to regular size after small

  • Chat header
    png 2018-07-12 12-53-26
  • Messages
    rel

4) There is no fixed smallest side for window
For Slack smallest window size is: 345X932
For Telegram: 484X873
In all cases user can use most app features.
For Status desktop there are no limits, and you can resize window to a state when it is not possible to work with application (screenshot below is resized window)
image

5) Tab-bar overlaps with the list of settings in the profile
dfsdf

Solution

Summary:

  • Add smallest fixed size, where application can be usable
  • Reduce CPU consumption during resize
  • Fix issue with automatic scroll
  • Fix issue with displaying messages/chat header in a row
  • Fix issue with overlapping tabs and profile

Additional Information

@churik
Copy link
Member Author

churik commented Aug 15, 2018

  1. Chat headers and messages are displayed in a column in a small-size window and doesn't get back if you resize window to normal size again - is fixed in Fixed layout recalculation for text react-native-desktop-qt#314

@vkjr
Copy link
Contributor

vkjr commented Aug 16, 2018

@chadyj, this issue was partially resolved by my last (unrelated) PR, but I had no intentions to fully finish it. So moving it back from "in progress"

@vkjr vkjr removed their assignment Aug 16, 2018
@ghost
Copy link

ghost commented Nov 14, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale label Nov 14, 2018
@ghost
Copy link

ghost commented Nov 21, 2018

This issue has been automatically closed. Please re-open if this issue is important to you.

@ghost ghost closed this as completed Nov 21, 2018
@churik
Copy link
Member Author

churik commented Nov 30, 2018

Still reproducible

@churik churik reopened this Nov 30, 2018
@ghost ghost removed the stale label Nov 30, 2018
@vkjr
Copy link
Contributor

vkjr commented Dec 1, 2018

@churik, I see CPU consumption on resize and absence of minimal app size.
Can you also reproduce chat scrolling when window resized? It looks good for me now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants