-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request chat history on demand while on cellular connection #7288
Comments
hey @andmironov, can you take a look, please? |
Started doing some explorations, here's iteration #1 (not final, needs to be discussed) Also, there should be on-demand syncing inside chats when syncing is off (i guess) cc @errorists |
@andmironov is that icon a permanent fixture in the navigation bar? If so, I strongly dislike this solution, we're not Dropbox, people shouldn't have to stare at a syncing icon inside a chat app :) I think including that would also undermine the perceived reliability of the network, this stuff should work without me having to think about it and only tell me if it doesn't. |
@andmironov, just one note: this issue is about syncing of messages history, not about syncing of blockchain state (which we will have soon as well). Those two processes are going to be separate. |
Here's an iteration 2, based on the initial @rasom 's concept. cc @mandrigin btw, implementing this requires implementing the bottom sheet component. Example of how it works can be found here https://framer.cloud/AvjzY by tapping on the little arrow icon next to "Emily". This component is super important and is used across all the app |
@andmironov, i'm ok with these screens, the only question is about that grey badge with offline status. As i remember quite a lot of people are annoyed by this badge atm and also it takes too much real estate on some screens (on chats list screen it blocks access to the first chat in the list, on chat screen it blocks the whole "add contact" badge, probably something else). |
@errorists, got it, thanks |
@errorists @andmironov i can't find this color in "Status Color", should i still use it? |
Nice catch! Please use light grey (#EEF2F5 RGB: 238, 242, 245) instead! mockup updated |
So happy to see this drawer in existence! Looks great. Any more work required? I notice:
@rasom can you please describe the behavior of when the drawer would come up as currently implemented? Looks like it comes up on the login screen instead of in the chat view. Any reason for this? |
@hesterbruikman please check this PR #7433 , the drawer will appear when you disable wifi |
Thanks @rasom I see the drawer also come up when Wi-Fi is disabled. I think this is cool, until 'Remember my choice is checked'. Didn't get a background on the drawer unfortunately (on Android). On iOS nothing seemed to happen, at all. Wondering if this is because of the build not working, because I don't have a SIM card or some other reason. |
hm, just tested on android |
Could be an issue unique to my ancient Android (6), in that case. Tried again with the build you shared, same result. |
@hesterbruikman ok I see, thanks, don't have such device to test |
@hesterbruikman what device do you have? |
hmmmmm interesting, I have Android 6.0.1 as well, but on a Fairphone. Shouldn't make a difference, but apparently it does:S |
Pivotal link
https://www.pivotaltracker.com/story/show/163186553
Problem
Currently, chats' history is requested from the mailservers regardless of what kind of internet connection is used on the device. For cellular connection, it might cause unacceptable traffic consumption.
Implementation
When network connection type changes to cellular a dialog with the next options can be shown to the user:
On
1.
and2.
a chosen action is applied and the same dialog is shown on next switching to the cellular network.If the user chooses
3.
or4.
a chosen action is applied and on the next occurrence the dialog "stop syncing while on cellular"/"continue syncing while on cellular" with two options can be shown:In order to not annoy the user with all these dialogs, it should be shown once per session (or once per some period of time). If we have some connection specific badge it might be shown to the user only once at all. But we still have to make settings easily accessible from almost any screen then (as well as that force-requesting button).
Acceptance Criteria
Notes
From UI/UX side we need:
The text was updated successfully, but these errors were encountered: