Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless loading indicator on Dapp view after opening universal link from within Dapp #7996

Closed
Serhy opened this issue Apr 18, 2019 · 5 comments

Comments

@Serhy
Copy link
Contributor

Serhy commented Apr 18, 2019

Type: Bug

Summary: When universal link (to public chat/contact profile) is opened from Dapp (or webpage) user is redirected to respective view (public chat view / user profile view) as expected. However, navigating back to Dapp screen - at the same time we load the universal link page (with 'Open in Status' button) which has several consequences:

  1. There is endless blue loading indicator on Dapp view
  2. URL of the Universal link is not disaplayes in URL bar
  3. < back browser button is not active, - so no way to navigate back to previous screen
  4. In the case universal link is for public chat -> tapping Open in Status button redirect user to public chat (again) and there is endless loading spinner on public chat (update: this part is Joining already joined public chat causes never ending "Loading..." #7952). Dapp screen will display now 'Unable to load page'

To eliminate all above, no need to open universal link webpage in a case when univeral link requested from withing Dapp. Please see steps to reproduce

Expected behavior

When user opens universal link to public chat or user profile in webpage/Dapp redirect to respective view happens and no https://get.status.im webpage is opened on Dapp screen
(should be the same behavior as if to paste-and-go universal link in Dapp view)

Actual behavior

Opening universal link from DappStore opens https://get.status.im/... webpage and there are consequences with it described above
Video: https://drive.google.com/file/d/1z4F-Eb4YXKIGCmCtxUlMPxOLV9e4LJas/view

Reproduction 1

  • Open Status and create new account
  • Navigate to Dapp tab -> open https://dap.ps webpage
  • Scroll to the bottom and tap any of Join the DApp community chat / Support elements
  • Navigate back to Dapp view

Reproduction 2

  • Open Status and create new account
  • Navigate to Dapp tab -> open https://people-ops.status.im/status-channels/ webpage
  • Tap any item from the list of public chats
  • Navigate back to Dapp view

Additional Information

  • Status version: Develop 20190418
  • Operating System: Android and iOS
@bitsikka
Copy link
Contributor

bitsikka commented Apr 18, 2019

4. In the case universal link is for public chat -> tapping Open in Status button redirect user to public chat (again) and there is endless loading spinner on public chat.

this part sounds like related to #7952 and if it is, as proposed in 7952, merging #7820 would fix it

@Serhy
Copy link
Contributor Author

Serhy commented Apr 18, 2019

  1. In the case universal link is for public chat -> tapping Open in Status button redirect user to public chat (again) and there is endless loading spinner on public chat.

this part sounds like related to #7952 and as proposed in it merging #7820 would fix it

Yes, thanks @bitsikka that's correct. There is a second public chat join activity happens, so it's #7952

@churik
Copy link
Member

churik commented Feb 26, 2020

should be retested after fix for #10083

@churik
Copy link
Member

churik commented Jun 10, 2020

still relevant on release 1.4

@hesterbruikman
Copy link
Contributor

Closing as I can no longer reproduce the issue (cc @Serhy @churik)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants