Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To warn user that for restoring all funds on multiaccount he needs to create all accounts manually #9159

Closed
churik opened this issue Oct 10, 2019 · 14 comments
Labels
feature feature requests

Comments

@churik
Copy link
Member

churik commented Oct 10, 2019

User Story

As a user, I want to be sure that I didn't lose my funds if I create several accounts inside my multiaccount when I need to restore it on other device.

Description

Currenty if you have multi-account with several accounts and funds on each of them, to restore multiaccount with all funds you need apart from restoring from seed phrase to create the corresponding number of accounts.
For example:

  • User has multi-account with Status account(1 ETH), account B (0.5 ETH), account C (0.5 ETH + 100 SNT)
  • Generally, it has 2 ETH and 100 SNT (it is shown on Wallet screen).

Let's say user lost his phone and restore account on another device.
All that he can see after restoring multiaccount from seed-phrase - Status account with 1 ETH.

To see all funds he needs to create account B and account C manually.

Summary: we should at least warn user that he needs to generate new accounts after restoring from seed phrase.

Acceptance Criteria

to restore all accounts or to warn user in some step that he needs to create accounts manually on each restoring.

@rachelhamlin @hesterbruikman @errorists looking forward to have your opinion on it.

@churik churik added feature feature requests v1 release labels Oct 10, 2019
@churik churik changed the title To warn user that for restoring all funds on multiaccount they need to create all accounts manually To warn user that for restoring all funds on multiaccount he needs to create all accounts manually Oct 10, 2019
@rachelhamlin
Copy link
Contributor

Wait, so, sorry I'm not testing myself @churik but...

Is it the case that, to recover my additional accounts, I have to go through the Add account > Add an account > Generate a new key flow...? Or is there a recovery flow there I'm missing?

In other words, what does it mean to create account B and account C manually?

@churik
Copy link
Member Author

churik commented Oct 10, 2019

@rachelhamlin
it means that you need to

  1. recover your account from seed phrase, and you will see only Status account
  2. then you need to go to wallet > Add account > Generate new account > Account B will be restored (address will be the same, but you can set new name \ color)
  3. and do step 2 again for Account C

In that case you will see all your funds.

@rachelhamlin
Copy link
Contributor

Wow, so. We could clue the user into this bizarro situation. But I would much rather restore all of their accounts altogether. That would be the right solution.

Is it possible @flexsurfer?

@flexsurfer
Copy link
Member

flexsurfer commented Oct 10, 2019

i believe we've discussed this, in the future we'll scan paths and restore all accounts with non zero balances

@yenda
Copy link
Contributor

yenda commented Oct 14, 2019

So what is the task here?

  • a warning?
  • scanning paths until 0 balance accounts? (but in this this case maybe we still need a warning, when do you stop scanning? maybe I created 10 accounts and only used the first and last?)

@rachelhamlin
Copy link
Contributor

@errorists I know how much you love warnings and error messages. Do you have any thoughts on how we could tell users that they need to manually recover their additional accounts by "generating a new key"? It's a bit shocking from a UX perspective, but the incidence of this occurring should be low. 🤞

I rate it P1.

@errorists
Copy link
Contributor

errorists commented Oct 17, 2019

@rachelhamlin sorry I missed this. I didn't work on multiaccount so will ping @andmironov instead, I'd assume/hope it was thought through at some point 🤞

I'm thinking of adding an additional step on account recovery that would inform users what they need to do on condition they want to access any additional accounts they had along with their balances, because it's not obvious at all.

@hesterbruikman
Copy link
Contributor

Discussed this with @gravityblast (tagging for accuracy). As I understood there is an API in Go that should allow to check for any funds on accounts derived from the mnemonic. If fund amount is >0 these accounts can be imported along with the recovered key.

Not sure what is required to implement this and whether it's more work, to implement a warning to move funds manually or to implement react use of the Go API.

Should indeed be a very rare case as only nightlies allowed creating multiple accounts in first place. I would even consider comms outside of the app for this and focus on implementing use of the API post-V1.

@gravityblast
Copy link
Member

yes we can use go to derive n addresses and checking the balance

@rachelhamlin
Copy link
Contributor

Wait @hesterbruikman, what do you mean that only nightlies allow creating multiple accounts?

On v1, all users will be able to create multiple multi-accounts, unless I missed something.

Though there seems to be very low incentive to do so.

@gravityblast could you share some sense of an estimate here? How big of an effort would it be to check account balances using the Go API, is it mainly work that needs to be done in status-react?

@hesterbruikman
Copy link
Contributor

Wait @hesterbruikman, what do you mean that only nightlies allow creating multiple accounts?

I meant allowed up until now. I would reasonably expect a very limited number of users to have had the chance to create multiple accounts up to this point. That makes this still an issue in V1, but not critical for a transition to V1.

@rachelhamlin
Copy link
Contributor

Agreed @hesterbruikman! I've left it as p1, though we don't have a plan yet.

@rachelhamlin
Copy link
Contributor

Simon ran into this after a crash in the browser while testing Teller. He had to recover his account because Status crashed and appeared to wipe his data. 😰

@cammellos
Copy link
Contributor

Closing in favor of #10973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Projects
None yet
Development

No branches or pull requests

9 participants