[#10734] Show message timestamps on tap, remove from bubbles 🕙 #12915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ajayesivan, and thank you so much for making your first pull request in status-react! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2 |
Jenkins BuildsClick to see older builds (12)
|
shivekkhurana
requested changes
Dec 15, 2021
| @@ -168,19 +183,15 @@ | |||
| (defn render-parsed-text [message tree] | |||
| (reduce (fn [acc e] (render-block message acc e)) [:<>] tree)) | |||
|
|
|||
| (defn render-parsed-text-with-timestamp [{:keys [timestamp-str outgoing edited-at in-popover?] :as message} tree] | |||
| (defn render-parsed-text-without-timestamp [message tree] | |||
There was a problem hiding this comment.
Can this function can be removed completely? Without the timestamp it just returns the elements list directly:
(let [elements [1 2 3 4]]
(conj (pop elements) (peek elements))) ;; => [1 2 3 4]There was a problem hiding this comment.
Yes, you are right. But since I'm moving the message status back to the bubble I'm reusing this function.
|
Thanks for the PR Ajay. This looks good to me overall. |
ajayesivan
force-pushed
the
feature/show-hide-chat-timestamp
branch
from
7c61d77 to
b4230dc
Compare
|
hey @ajayesivan thanks for the contribution, but I think status should stay in the message , only timestamp should be moved |
@flexsurfer What about the edited status? Should that stay too? |
i believe yes |
|
@flexsurfer I have moved the 'message status' & 'edit info' back to the message bubble. Thanks for pointing that out 😊. Updated the preview/gif with the new behavior. |
shivekkhurana
approved these changes
Dec 15, 2021
83% of end-end tests have passedFailed tests (12)Click to expand
Passed tests (57)Click to expand |
33% of end-end tests have passedFailed tests (8)Click to expand
Passed tests (4)Click to expand
|
|
@ajayesivan thanks for your work! ISSUE 1: Timestamps are still displayed in transaction message bubbles in 1-1 chatsReproduction:
|
@qoqobolo Thanks for moving so fast! I checked this issue. |
|
@ajayesivan yes, you're right. Testing is still ongoing. I'll ping you once it's finished or other issues are found. |
0% of end-end tests have passedFailed tests (6)Click to expand
|
|
@ajayesivan thanks for the contribution again!
Failed e2e tests are not related to PR. |
|
@ajayesivan could you please rebase and squash commits please |
ajayesivan
force-pushed
the
feature/show-hide-chat-timestamp
branch
from
9b0ce2e to
1d07d80
Compare
@flexsurfer Done |
Signed-off-by: andrey <[email protected]>
flexsurfer
force-pushed
the
feature/show-hide-chat-timestamp
branch
from
1d07d80 to
f3533c5
Compare
|
@ajayesivan thanks for the amazing contribution! Thanks a lot for your effort, this is a great contribution. |
2 tasks
|
@cammellos Thanks for the update. I have submitted the application. |
|
thanks @ajayesivan |
|
@cammellos Done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10734
Summary
Visible timestamps on all bubbles clutter up the chat and add noise when they're not needed. This PR removes the timestamp from the message bubble. Users can tap on a message and the timestamp will fade in on the longer margin side of the message.
UI Changes
Platforms
Areas that maybe impacted
Functional
Steps to test
status: ready