Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#9138] Missing translation in "Need help" section ("Ask a question") #9146

Merged
merged 1 commit into from
Oct 9, 2019
Merged

[#9138] Missing translation in "Need help" section ("Ask a question") #9146

merged 1 commit into from
Oct 9, 2019

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Oct 9, 2019 •
edited by StatusWrike
Loading

fixes #9138

@flexsurfer flexsurfer requested a review from a team as a code owner October 9, 2019 09:03
@auto-assign auto-assign bot removed the request for review from a team October 9, 2019 09:03
@ghost
Copy link

ghost commented Oct 9, 2019

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@flexsurfer flexsurfer self-assigned this Oct 9, 2019
@flexsurfer flexsurfer requested review from dmitryn and vitvly October 9, 2019 09:03
@status-im-auto
Copy link
Member

status-im-auto commented Oct 9, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8770818 #1 2019-10-09 09:14:43 ~11 min ios 📦ipa 📲
✔️ 8770818 #1 2019-10-09 09:16:38 ~13 min macos 📦dmg
✔️ 8770818 #1 2019-10-09 09:16:59 ~13 min android 📦apk 📲
✔️ 8770818 #1 2019-10-09 09:17:07 ~13 min linux 📦App
✔️ 8770818 #1 2019-10-09 09:18:04 ~14 min android-e2e 📦apk 📲
✔️ 8770818 #1 2019-10-09 09:18:10 ~14 min windows 📦exe

@flexsurfer flexsurfer force-pushed the bug/translation-request-feature branch from 8770818 to ca41fef Compare October 9, 2019 13:24
@flexsurfer flexsurfer merged commit ca41fef into develop Oct 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the bug/translation-request-feature branch October 9, 2019 13:24
@weekly-digest weekly-digest bot mentioned this pull request Oct 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitvly vitvly vitvly approved these changes

@dmitryn dmitryn Awaiting requested review from dmitryn

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing translation in "Need help" section ("Ask a question")
3 participants
@flexsurfer @status-im-auto @vitvly