Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird styling of contact page #20

Closed
jakubgs opened this issue Feb 10, 2020 · 5 comments
Closed

Weird styling of contact page #20

jakubgs opened this issue Feb 10, 2020 · 5 comments

Comments

@jakubgs
Copy link
Member

jakubgs commented Feb 10, 2020

I've deployed the changes from #19 and it looks kinda weird:

get_status_im_update

https://get.status.im/user/0x04e139115a1acc72510388fcf7e1cf492784c9a839888b25271465f4f1baa38c2d3997f8fd78828eb8628bc3bb55ababd884c6002d18330d59c404cc9ce3e4fb35

@hesterbruikman @NistorCristian

@hesterbruikman
Copy link
Contributor

Noticing a few issues here:

  • Scanning QR code from https://get.status.im/user/hester in Status New chat results in error 'Unable to read code Please enter or scan a valid chat key or username'
  • Copy copies the full text, intention is to copy only the ENS name or chat key
  • Download button should eventually be contextually dependent on whether Status is installed. For the time being this should go to https://status.im/get/
  • There's a lot of unnecessary javascript as @errorists raised here top navigation and footer would ideally be shared with the main domain and not loaded again.

@jakubgs
Copy link
Member Author

jakubgs commented Feb 10, 2020

I've reverted the https://get.status.im/ page to 9b181a2.

@errorists
Copy link

another thing that needs addressing
• Both the Header and subtitle in the box below QR, should only say the username without the entire view user profile in Status string. so instead of View user hester profile in Status it should rather say hester or 0x041…2f20
The same with text string below the button too. All of them have the same bs text string instead of just the actual username/key.

@jakubgs
Copy link
Member Author

jakubgs commented Feb 10, 2020

I've deployed changes from #21 and it looks good now.

get_status_style_fix

I also increased QR code resolution in 9f9be81 because it looked too fuzzy.

@jakubgs jakubgs closed this as completed Feb 10, 2020
@hesterbruikman
Copy link
Contributor

hesterbruikman commented Feb 11, 2020

Awesome @jakubgs ! Looks good now!
One last check. Does the QR code work for you when your ENS name is included?

Sorry, I hadn't caught up on this issue yet: status-im/status-mobile#10017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants