Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include QR code for join.status.im/chat/... #25

Closed
hesterbruikman opened this issue Feb 12, 2020 · 3 comments
Closed

Include QR code for join.status.im/chat/... #25

hesterbruikman opened this issue Feb 12, 2020 · 3 comments

Comments

@hesterbruikman
Copy link
Contributor

Problem

Currently join.status.im/user/... shows a QR code for the chat key and ENS name (whichever is in the url). In case of a public or group chat, no QR code is shown.

Copy could use updates:

❌ Chat in a public channel #status in Status
✔️ Join public channel #status on Status

❌ Header Status
✔️ Header #Status

Screenshot_20200212-135245_Firefox

@hesterbruikman
Copy link
Contributor Author

@jakubgs do you have any thoughts on how to add a QR code for public channels?
Also, if you can point me to the language file I can make the copy edits of this issue.

@jakubgs
Copy link
Member

jakubgs commented Feb 12, 2020

I can do this. It should be easy.

@jakubgs
Copy link
Member

jakubgs commented Feb 12, 2020

But there is an issue here. Because the app has no way of distinguishing between a username and a chat name. Lets say I have a QR code for whatever, is that a whatever.stateofus.eth ENS or is that a #status chat name?

There are 2 ways of solving this as far as I can tell:

  1. Use the status-im:// format in QR codes so it's contents are:
  • status-im://chat/public/whatever or
  • status-im://user/whatever
  1. Always provide full ENS name, and always prefix chat names with #:
  • whatever.stateofus.eth
  • #whatever

The former is easier to handle, but the latter is more concise and gives smaller QR codes.

This needs to be decided upon and implemented both in the app and in this repo.
My status-im/status-mobile#10017 issue touches on this specific subject.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants