Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements for line shapes #197

Closed
JCGoran opened this issue Jul 15, 2024 · 1 comment · Fixed by #206
Closed

Performance improvements for line shapes #197

JCGoran opened this issue Jul 15, 2024 · 1 comment · Fixed by #206
Labels
enhancement New feature or request
Milestone

Comments

@JCGoran
Copy link
Contributor

JCGoran commented Jul 15, 2024

Is your feature request related to a problem? Please describe.

The performance of the line shape could be improved, as the performance is a bit slow compared to the circular shapes.
For some performance numbers (tested with cProfile):

python -m cProfile -m data_morph --start-shape panda --target-shape star
320361688 function calls (316213771 primitive calls) in 116.715 seconds

Compare with:

python -m cProfile -m data_morph --start-shape panda --target-shape bullseye
83940221 function calls (83300500 primitive calls) in 41.067 seconds

Seems to be a factor of 4 more function calls, resulting in roughly 3x slower performance.

Describe the solution you'd like

Faster evaluation of line-line shapes.

Describe alternatives you've considered

None.

Additional context

None.

Copy link

It looks like this is your first issue here – welcome! Please familiarize yourself with the contributing guidelines, if you haven't already.

@stefmolin stefmolin added the enhancement New feature or request label Jul 16, 2024
@stefmolin stefmolin added this to the 0.3.0 milestone Jul 16, 2024
@stefmolin stefmolin linked a pull request Aug 30, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants