Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default HTTP client when not provided #1182

Closed
bartekn opened this issue Apr 25, 2019 · 1 comment
Closed

Set default HTTP client when not provided #1182

bartekn opened this issue Apr 25, 2019 · 1 comment
Assignees
@poliha
Labels
horizonclient tag for new horizon client located in clients/horizonclient

Comments

@bartekn
Copy link
Contributor

bartekn commented Apr 25, 2019

I created a new client like:

horizon := client.Client{
	HorizonURL: HorizonOld,
}

I think that if HTTP field is not set, client package should default to http.DefaultClient (or better: client with reasonable timeouts).
@bartekn bartekn added the horizonclient tag for new horizon client located in clients/horizonclient label Apr 25, 2019
@poliha poliha mentioned this issue May 2, 2019
Merged
@poliha
Copy link
Contributor

poliha commented May 6, 2019

closed in #1228

@poliha poliha closed this as completed May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poliha poliha

Labels
horizonclient tag for new horizon client located in clients/horizonclient
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bartekn @poliha