Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransactionBuilder.fromXDR() does not support muxed accounts #471

Closed
JakeUrban opened this issue Sep 15, 2021 · 1 comment
Closed

TransactionBuilder.fromXDR() does not support muxed accounts #471

JakeUrban opened this issue Sep 15, 2021 · 1 comment
Assignees
@Shaptic @JakeUrban
Labels
bug

Comments

@JakeUrban
Copy link

Describe the bug

We missed adding the withMuxing argument to the follow call (#L391):

return new Transaction(envelope, networkPassphrase);

We likely need to use the TransactionBuilder.supportMuxedAccounts attribute defined in the object's initialization:

return new Transaction(envelope, networkPassphrase, this.supportMuxedAccounts);

What version are you on?

6.0.3
@JakeUrban JakeUrban added the bug label Sep 15, 2021
@JakeUrban JakeUrban mentioned this issue Sep 15, 2021
Merged
@Shaptic
Copy link
Contributor

Shaptic commented Oct 21, 2021

I believe this is closed by #470 and v6.0.4.

@Shaptic Shaptic closed this as completed Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shaptic Shaptic

@JakeUrban JakeUrban

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Shaptic @JakeUrban