You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
If you pass in a number instead of a string for either maxAmountA or maxAmountB field of the liquidityPoolDeposit operation, the error thrown is TypeError: maxAmountA argument is required, which is misleading as the error is due to an incorrect type.
What version are you on?
stellar-base version 7.0.0
stellar-sdk version 10.0.1
Expected behavior
A possible easy remedy could be changing the error to: TypeError: invalid maxAmountA argument. Required and must be string, or something similar.
Additional context
although the type is clearly shown as string in the sdk docs, the error thrown doesn't give an accurate description of the error and gave me some confusion while developing :) . Changing could save devs that confusion when using the new AMM functionality of the SDK.
The text was updated successfully, but these errors were encountered:
Describe the bug
If you pass in a number instead of a string for either maxAmountA or maxAmountB field of the
liquidityPoolDeposit
operation, the error thrown isTypeError: maxAmountA argument is required
, which is misleading as the error is due to an incorrect type.What version are you on?
stellar-base version 7.0.0
stellar-sdk version 10.0.1
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A possible easy remedy could be changing the error to:
TypeError: invalid maxAmountA argument. Required and must be string
, or something similar.Additional context
although the type is clearly shown as string in the sdk docs, the error thrown doesn't give an accurate description of the error and gave me some confusion while developing :) . Changing could save devs that confusion when using the new AMM functionality of the SDK.
The text was updated successfully, but these errors were encountered: