From e1c8be6e2c5889a75fdc34f35ccab4082aeb624f Mon Sep 17 00:00:00 2001 From: George Kudrayvtsev Date: Thu, 27 Jun 2024 11:14:34 -0700 Subject: [PATCH 1/3] Use the int .value of the type instead of object comparison --- src/asset.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/asset.js b/src/asset.js index 5f3b33d0..eb74e69d 100644 --- a/src/asset.js +++ b/src/asset.js @@ -185,12 +185,12 @@ export class Asset { * - `unknown` as the error case (which should never occur) */ getAssetType() { - switch (this.getRawAssetType()) { - case xdr.AssetType.assetTypeNative(): + switch (this.getRawAssetType().value) { + case xdr.AssetType.assetTypeNative().value: return 'native'; - case xdr.AssetType.assetTypeCreditAlphanum4(): + case xdr.AssetType.assetTypeCreditAlphanum4().value: return 'credit_alphanum4'; - case xdr.AssetType.assetTypeCreditAlphanum12(): + case xdr.AssetType.assetTypeCreditAlphanum12().value: return 'credit_alphanum12'; default: return 'unknown'; From 33cf253f03baa7071afe6340a41e83a91abd5dde Mon Sep 17 00:00:00 2001 From: George Kudrayvtsev Date: Thu, 27 Jun 2024 11:15:54 -0700 Subject: [PATCH 2/3] Remove extraneous test logging --- test/unit/soroban_test.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/unit/soroban_test.js b/test/unit/soroban_test.js index 9369a9f3..b91f8432 100644 --- a/test/unit/soroban_test.js +++ b/test/unit/soroban_test.js @@ -1,7 +1,6 @@ describe('Soroban', function () { it('should have XDR serialization', function () { expect(StellarBase.cereal).not.to.be.undefined; - console.log(StellarBase.cereal); }); describe('formatTokenAmount', function () { From c00dadb2536046791e393b47a6b8071250e47686 Mon Sep 17 00:00:00 2001 From: George Kudrayvtsev Date: Thu, 27 Jun 2024 11:17:57 -0700 Subject: [PATCH 3/3] Add changelog entry --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a4c98dcc..aee86b26 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +### Fixed +* Improve the efficiency and portability of asset type retrieval ([#758](https://github.com/stellar/js-stellar-base/pull/758)). + ## [`v12.0.1`](https://github.com/stellar/js-stellar-base/compare/v12.0.0...v12.0.1)