Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction parsing is broken #646

Closed
orbitlens opened this issue May 11, 2021 · 1 comment · Fixed by stellar/js-stellar-base#429
Closed

Transaction parsing is broken #646

orbitlens opened this issue May 11, 2021 · 1 comment · Fixed by stellar/js-stellar-base#429
Labels

Comments

@orbitlens
Copy link

Describe the bug
TransactionBuilder.fromXDR call causes an error during parsing XDR for some transactions.

What version are you on?
8.1.1

To Reproduce

const {TransactionBuilder} = require("stellar-sdk")

TransactionBuilder.fromXDR('AAAAAgAAAABg/GhKJU5ut52ih6Klx0ymGvsac1FPJig1CHYqyesIHQAAJxACBmMCAAAADgAAAAAAAAABAAAAATMAAAAAAAABAAAAAQAAAABg/GhKJU5ut52ih6Klx0ymGvsac1FPJig1CHYqyesIHQAAAAAAAAAAqdkSiA5dzNXstOtkPkHd6dAMPMA+MSXwK8OlrAGCKasAAAAAAcnDgAAAAAAAAAAByesIHQAAAEAuLrTfW6D+HYlUD9y+JolF1qrb40hIRATzsQaQjchKJuhOZJjLO0d7oaTD3JZ4UL4vVKtV7TvV17rQgCQnuz8F', 'Public Global Stellar Network ; September 2015')

The code above causes an error

TypeError: medKey.ed25519 is not a function
  at Function.encodeEd25519PublicKey in stellar-base/lib/strkey.js — line 73
  at encodeMuxedAccountToAddress in stellar-base/lib/util/decode_encode_muxed_account.js — line 81
...

Possibly related to #645

Expected behavior
No error thrown.

Additional context
Looks like the problem emerged after upgrading to the latest stellar-sdk + stellar-base.

@Shaptic
Copy link
Contributor

Shaptic commented May 11, 2021

Thank you for this; it's resolved by stellar/js-stellar-base#429 and will be included in base-5.2.1 and subsequently the pending sdk-8.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants