Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add userns_mode and cap_drop fields to Service #32

Closed
k9withabone opened this issue Dec 9, 2023 · 2 comments · Fixed by #33
Closed

Add userns_mode and cap_drop fields to Service #32

k9withabone opened this issue Dec 9, 2023 · 2 comments · Fixed by #33

Comments

@k9withabone
Copy link
Contributor

It was brought to my attention (containers/podlet#31) by one of the users of my podlet project, that the Service struct is missing the userns_mode field. See the linked issue for documentation for the field. Looking at Service's documentation just now I also noticed that the cap_drop field is also missing.
@stephanbuys
Copy link
Owner

@k9withabone do you want to submit a PR with the fix? I would just need some type information for those two fields to add it otherwise.

@k9withabone
Copy link
Contributor Author

Yup, I got it.

@k9withabone k9withabone mentioned this issue Dec 10, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add cap_drop and userns_mode fields to Service k9withabone/docker-compose-types
2 participants
@stephanbuys @k9withabone