Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong WithImageFS usage in README #24

Open
117503445 opened this issue Nov 26, 2024 · 0 comments
Open

wrong WithImageFS usage in README #24

117503445 opened this issue Nov 26, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@117503445
Copy link

The README states pdf.WithImageFS(os.DirFS(".")), but the actual method signature is func WithImageFS(images http.FileSystem) Option. Shouldn't it be pdf.WithImageFS(http.FS(os.DirFS("."))) instead?
@stephenafamo stephenafamo added the documentation Improvements or additions to documentation label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenafamo @117503445