Broken SVG Links

[derappelt]

Svg anchor tags return an object( {baseVal:string, animVal:string} ) instead of an string.
This causes react-snap to throw an error

[stereobooster]

Hi. Thank you for contribution. Can you please add test-case for this?

[derappelt]

Does this test cover enough for you?

[derappelt]

Any feedback on this?
Even a simple:
(anchor => (typeof anchor.href === 'string') ? anchor.href : '')
Would be a better solution.
Me and my team really like react-snap. But this bug keeps us away from using it.

[stereobooster]

Oh yes, sorry. I was distracted. Everything looks fine, I just want to run some tests, to make sure I understand what is happening.

[derappelt]

Thanks no problem!
I'm not quite sure if my submitted code covers all SVG Link cases. But it works in all projects I tried so far.
Like I mentioned in my comment above, I think the first priority should be that Inline SVG Links don't crash snap.

[stereobooster]

Suggested change

	return location.origin + anchor.href.baseVal;
	const a = document.createElement("a");
	a.href = anchor.href.baseVal;
	return a.href;

[stereobooster]

There is small thing to change, but I can do it. Thanks