New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock File #12

Closed

matthewtrask opened this issue Jan 14, 2018 · 1 comment

matthewtrask commented Jan 14, 2018

There should be a committed lock file in the repo so anyone who clones down this repo will have the exact versions of libraries you do :)

Owner

stevegrunwell commented Jan 14, 2018

There was one up until today (see #8) — @mhujer brought up some good points about the use of composer.lock files in libraries (as opposed to projects). Removing the composer.lock file from libraries ensures the CI scripts can test different versions of dependencies (in this case, the lowest-compatible version, ala #9) and the latest.

stevegrunwell closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment