Switch to cmake #49
Merged
Switch to cmake #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was referenced Jul 5, 2016
Closed
|
any idea on the PR? @stevengj |
| check_function_exists (getpid HAVE_GETPID) | ||
| check_function_exists (syscall HAVE_GETTID_SYSCALL) | ||
| check_function_exists (isinf HAVE_ISINF) | ||
| check_function_exists (isnan HAVE_ISNAN) |
There was a problem hiding this comment.
On some systems, I vaguely recall that isinf/isnan are macros rather than functions. Does check_function_exists handle this case?
There was a problem hiding this comment.
Oh, I see that you had to handle this separately with fpclassify below.
There was a problem hiding this comment.
I suppose it doesn't make a difference if it's a macro or a function.
|
Okay, merged.... |
This was referenced Jul 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes autotools and adds missing features to cmake.
It superseeds PRs #41, #67.
Some tests are run for win32/msvc 2015, linux/gcc and osx/clang.