Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Commit

Permalink
refactor(node.js): chainable methods no longer return this
Browse files Browse the repository at this point in the history
BREAKING CHANGE:
removeChild(), appendChild(), appendChildBefore(), appendChildAfter()
and replaceChild no longer return this.
  • Loading branch information
stfsy committed Mar 27, 2017
1 parent 7710fd3 commit 42d0548
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions lib/node.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,6 @@ class Node {
elements.forEach((element) => {
domUtils.removeElement(element)
})

return this
}

/**
Expand All @@ -228,8 +226,6 @@ class Node {
*/
appendChild(newChild) {
domUtils.appendChild(this._element, newChild.get())

return this
}

/**
Expand All @@ -240,8 +236,6 @@ class Node {
*/
appendChildBefore(newChild, existingChild) {
domUtils.prepend(existingChild.get(), newChild.get())

return this
}

/**
Expand All @@ -252,8 +246,6 @@ class Node {
*/
appendChildAfter(newChild, existingChild) {
domUtils.append(existingChild.get(), newChild.get())

return this
}

/**
Expand All @@ -264,8 +256,6 @@ class Node {
*/
replaceChild(newChild, existingChild) {
domUtils.replaceElement(existingChild.get(), newChild.get())

return this
}

/**
Expand Down

0 comments on commit 42d0548

Please sign in to comment.