HardwareSerial's flush() method to override the method of the base class Print #2254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following bugs/features
void flush()
method not being overridden by derivative HardwareSerial'svoid flush(uint32_t timeout = 0)
method.The base class Print defines
void flush()
, while the derivative HardwareSerial definesvoid flush(uint32_t timeout = 0)
. The issue was that when using the base class instance pointer, the virtual function of the derivative was not being called. This PR resolves this.I might be missing something since I am new to this project, so please feel free to correct me :)