Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take x-nullable into consideration for oas2 valid examples #1359

Closed
igas opened this issue Sep 30, 2020 · 3 comments · Fixed by #1378
Closed

Take x-nullable into consideration for oas2 valid examples #1359

igas opened this issue Sep 30, 2020 · 3 comments · Fixed by #1378
Assignees
Labels
t/bug Something isn't working v6 Scheduled to be released in v6

Comments

@igas
Copy link

igas commented Sep 30, 2020

Describe the bug

oas2-valid-response-schema-example does not consider x-nullable

To Reproduce

  1. clone https://github.com/igas/examples-examples
  2. spectral lint oas2.yaml
  3. See error 63:24 error oas2-valid-response-schema-example nickname property type should be string

Expected behavior
Because nickname has x-nullable I expect it not to raise error

Additional context
I believe it's related to #1284 as it started failing with 5.5.0 upgrade attempt

@igas igas added the t/bug Something isn't working label Sep 30, 2020
@P0lip P0lip self-assigned this Oct 8, 2020
@igas
Copy link
Author

igas commented Oct 11, 2020

Thanks @P0lip!

@corroded
Copy link

@P0lip Curious why this was reverted in master? 621c025

@P0lip
Copy link
Contributor

P0lip commented Dec 11, 2020

@corroded Hey. I had to revert it since patch-package didn't work too well with npm installations of Spectral.
Binaries worked just fine. I'll revisit it soon - I'm hoping to get it out in one of the next releases.

@P0lip P0lip added the v6 Scheduled to be released in v6 label Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t/bug Something isn't working v6 Scheduled to be released in v6
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants