Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help creating bundle run in Node JS and browser #846

Closed
oreshkin-ay opened this issue Dec 11, 2019 · 2 comments · Fixed by #850
Closed

Help creating bundle run in Node JS and browser #846

oreshkin-ay opened this issue Dec 11, 2019 · 2 comments · Fixed by #850
Labels

Comments

@oreshkin-ay
Copy link

Trying to create bundle format: 'umd'. It works in the browser. But gives an error message run node.
Config rollup:
image
image

@P0lip
Copy link
Contributor

P0lip commented Dec 11, 2019

Hey! I'm going to address the nanoid issue today. AFAIR we don't need to generate secure ids, so it should be perfectly fine to use a plain math random.
This should fix the issue.
Re the rollup setup - you may still need to keep it.

@P0lip
Copy link
Contributor

P0lip commented Dec 11, 2019

I've just fixed the issue with nanonid. It's been released as 5.0.0-beta2. Feel free to check it out.
If you do need to stick to v4.2.x for the time being, try aliasing nanoid module to nanoid/non-secure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants