Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dereference circular anchor refs [SD-279] #10

Merged
merged 5 commits into from
Apr 17, 2019
Merged

feat: dereference circular anchor refs [SD-279] #10

merged 5 commits into from
Apr 17, 2019

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Apr 17, 2019 •
edited
Loading

TODO:

  • more tests

@P0lip P0lip force-pushed the bug/SD-279/cirular-refs branch from ea5b507 to fb18576 Compare April 17, 2019 00:59
@P0lip P0lip force-pushed the bug/SD-279/cirular-refs branch from 6d8d943 to a3f116a Compare April 17, 2019 14:38
@P0lip P0lip requested review from XVincentX and marbemac and removed request for XVincentX April 17, 2019 14:38
@P0lip P0lip requested a review from lottamus April 17, 2019 14:45
lottamus
lottamus approved these changes Apr 17, 2019
View reviewed changes
Copy link

@lottamus lottamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good. Nice work! Is this an underlying issue with yaml-ast-parser? Would they accept a PR?

@P0lip
Copy link
Contributor Author

P0lip commented Apr 17, 2019

Is this an underlying issue with yaml-ast-parser? Would they accept a PR?

I would say they handle it correctly. If we didn't serialize this data, I would leave it as is.
Luckily, I doubt we will happen to see such malformed YAML content often.
That way of referencing is some sort of 'syntax error', so to say.

@P0lip P0lip merged commit a5b87e8 into master Apr 17, 2019
@P0lip P0lip deleted the bug/SD-279/cirular-refs branch April 17, 2019 15:45
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lottamus lottamus lottamus approved these changes

@marbemac marbemac Awaiting requested review from marbemac

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P0lip @stoplight-bot @lottamus