feat: support CLRF #15
Conversation
|
Actually nvm, it's supported quite correctly, I think. |
|
Don't merge it yet. |
P0lip
force-pushed
the
feat/STU-296/clrf-support
branch
from
309a12d to
c989ec5
Compare
| @@ -0,0 +1,6 @@ | |||
| --- | |||
There was a problem hiding this comment.
This is a bit weird case.
Usually, our YAML files start with actual nodes... but not on this occasion.
I decided to report 0 line and 0 character if a given path cannot be found in a document.
Reporting actual character does not make much sense since there is no node there anyway.
Ideally, we would report the second line, as this is where the actual document starts.
@marbemac thoughts? Going with the latter idea will require a few changes, but it's doable.
There was a problem hiding this comment.
How is --- represented in the AST? What happens in the following situation - what line is Foo reported as?
---
---
Foo
| }); | ||
|
|
||
| it('should handle null-ish items', () => { | ||
| const result = parseWithPointers(`----~ |
There was a problem hiding this comment.
Discovered this issue while playing around with fixtures.
Unfortunately, yaml-ast-parser typings are broken, and they don't take nulls into account at all, even though most of the nodes or properties are nullable.
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.