Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support big integers #44

Merged
merged 2 commits into from
May 12, 2020
Merged

feat: support big integers #44

merged 2 commits into from
May 12, 2020

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented May 12, 2020

@P0lip P0lip added the enhancement New feature or request label May 12, 2020
@P0lip P0lip requested review from marbemac and a team May 12, 2020 14:04
@P0lip P0lip self-assigned this May 12, 2020
@P0lip P0lip marked this pull request as draft May 12, 2020 14:05
@P0lip P0lip marked this pull request as ready for review May 12, 2020 14:44
@P0lip P0lip marked this pull request as ready for review May 12, 2020 14:44
mallachari
mallachari approved these changes May 12, 2020
View reviewed changes
Copy link

@mallachari mallachari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@P0lip P0lip merged commit 590785a into master May 12, 2020
@P0lip P0lip deleted the feat/big-ints branch May 12, 2020 20:43
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@philsturgeon
Copy link

Does this close https://github.com/stoplightio/studio/issues/414? It's still open.

@P0lip
Copy link
Contributor Author

P0lip commented Feb 4, 2021

Nah, it doesn't. It's just one piece of a puzzle. :D
That said, we might be already capable of supporting big ints in Studio, due to the work we did here https://github.com/stoplightio/platform-internal/pull/4186.
Would need to verify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mallachari mallachari mallachari approved these changes

@marbemac marbemac Awaiting requested review from marbemac

Assignees

@P0lip P0lip

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@P0lip @stoplight-bot @philsturgeon @mallachari