Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update stoplight types #49

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Conversation

pytlesk4
Copy link
Contributor

No description provided.

@pytlesk4 pytlesk4 self-assigned this Jun 24, 2020
@marbemac
Copy link
Contributor

marbemac commented Jun 24, 2020

careful w chore, if you want this released. i guess fix?

@pytlesk4 pytlesk4 merged commit 905b799 into master Jun 24, 2020
@pytlesk4 pytlesk4 deleted the feat/update-stoplight-types branch June 24, 2020 17:07
@pytlesk4
Copy link
Contributor Author

I keep using feat, but I should use fix, dang it.

@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@P0lip
Copy link
Contributor

P0lip commented Jun 24, 2020

FWIW, I'd say we don't need to update @stoplight/{yaml,json} at all in when @stoplight/ypes is updated, unless:

  • it's a breaking change
  • it changes types the package makes use of

Both json and yaml don't make any use of NodeType, and this will lead to code duplication, because Spectral has version locked, so we will end up including two versions of yaml & json again (I deduped hours ago 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants