Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peer dependency for React 18 [Bug] #46

Closed
jasperswart opened this issue Oct 19, 2022 · 2 comments
Closed

Add peer dependency for React 18 [Bug] #46

jasperswart opened this issue Oct 19, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@jasperswart
Copy link

jasperswart commented Oct 19, 2022

Describe the bug

A clear and concise description of what the bug is.

Steps to reproduce the behavior

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

peer dependency for React 18

A clear and concise description of what you expected to happen.

Screenshots and/or logs

If applicable, add screenshots and/or logs to help explain your problem.

Environment

  • Node.js version: 16
  • NPM version: [e.g. 6.14.4]
  • Browser any
  • Browser version any
  • Device command line error

Additional context

At the moment this bug is causing our library of react components to still be reactc17.

This is a breaking issue for us!

Add any other context about the problem here.

@jasperswart jasperswart added the bug Something isn't working label Oct 19, 2022
@florian-milky
Copy link

workaround in your package.json:

"overrides": {
    "@storybook/addon-knobs": {
      "react": "$react"
    }
  },

@literalpie
Copy link
Collaborator

I believe this was fixed in #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants