From 2b256d3beda4d89d6d7468e730636b3e5d050e7e Mon Sep 17 00:00:00 2001 From: Michael Shilman Date: Fri, 12 Aug 2022 20:44:12 +0800 Subject: [PATCH] Apply suggestions from code review --- code/lib/builder-manager/src/index.ts | 6 +++--- code/lib/builder-manager/src/utils/files.ts | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/code/lib/builder-manager/src/index.ts b/code/lib/builder-manager/src/index.ts index 28dbbb8df04f..9b1d96323265 100644 --- a/code/lib/builder-manager/src/index.ts +++ b/code/lib/builder-manager/src/index.ts @@ -21,7 +21,7 @@ import { } from './types'; import { getData } from './utils/data'; import { safeResolve } from './utils/safeResolve'; -import { readOrdererFiles } from './utils/files'; +import { readOrderedFiles } from './utils/files'; // eslint-disable-next-line import/no-mutable-exports export let compilation: Compilation; @@ -120,7 +120,7 @@ const starter: StarterFunction = async function* starterGeneratorFn({ router.use(`/sb-addons`, express.static(addonsDir)); router.use(`/sb-manager`, express.static(coreDirOrigin)); - const { cssFiles, jsFiles } = await readOrdererFiles(addonsDir); + const { cssFiles, jsFiles } = await readOrderedFiles(addonsDir); yield; @@ -185,7 +185,7 @@ const builder: BuilderFunction = async function* builderGeneratorFn({ startTime, yield; const managerFiles = copy(coreDirOrigin, coreDirTarget); - const { cssFiles, jsFiles } = await readOrdererFiles(addonsDir); + const { cssFiles, jsFiles } = await readOrderedFiles(addonsDir); yield; diff --git a/code/lib/builder-manager/src/utils/files.ts b/code/lib/builder-manager/src/utils/files.ts index 07c963e19c8a..56c6204ead56 100644 --- a/code/lib/builder-manager/src/utils/files.ts +++ b/code/lib/builder-manager/src/utils/files.ts @@ -1,7 +1,7 @@ import { writeFile, ensureFile } from 'fs-extra'; import { compilation } from '../index'; -export async function readOrdererFiles(addonsDir: string) { +export async function readOrderedFiles(addonsDir: string) { const files = await Promise.all( compilation?.outputFiles?.map(async (file) => { await ensureFile(file.path).then(() => writeFile(file.path, file.contents));