From ad444a3832c8ae3fa41f8996087d99e97dc5a16f Mon Sep 17 00:00:00 2001 From: Tom Coleman Date: Wed, 26 Oct 2022 13:43:20 +1100 Subject: [PATCH 1/2] Ensure v6 store works even with no explicit renderer --- code/lib/core-common/src/utils/get-renderer-name.ts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/code/lib/core-common/src/utils/get-renderer-name.ts b/code/lib/core-common/src/utils/get-renderer-name.ts index 375190affb60..e0dacb269bcb 100644 --- a/code/lib/core-common/src/utils/get-renderer-name.ts +++ b/code/lib/core-common/src/utils/get-renderer-name.ts @@ -1,5 +1,5 @@ -import { dedent } from 'ts-dedent'; import type { Options } from '@storybook/types'; +import { getFrameworkName } from './get-framework-name'; /** * Render is set as a string on core. It must be set by the framework @@ -8,11 +8,10 @@ export async function getRendererName(options: Options) { const { renderer } = await options.presets.apply('core', {}, options); if (!renderer) { - throw new Error(dedent` - You must specify a framework in '.storybook/main.js' config. - - https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#framework-field-mandatory - `); + console.log('getting framework name'); + // At the moment some frameworks (Angular/Ember) do not define a renderer, but themselves + // serve the purpose (in particular exporting the symbols needed by entrypoints) + return getFrameworkName(options); } return renderer; From 1c91324a0c193e47f5fdb6a4d86a0821435fa14e Mon Sep 17 00:00:00 2001 From: Tom Coleman Date: Wed, 26 Oct 2022 15:00:34 +1100 Subject: [PATCH 2/2] Update code/lib/core-common/src/utils/get-renderer-name.ts --- code/lib/core-common/src/utils/get-renderer-name.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/code/lib/core-common/src/utils/get-renderer-name.ts b/code/lib/core-common/src/utils/get-renderer-name.ts index e0dacb269bcb..35131f5e0090 100644 --- a/code/lib/core-common/src/utils/get-renderer-name.ts +++ b/code/lib/core-common/src/utils/get-renderer-name.ts @@ -8,7 +8,6 @@ export async function getRendererName(options: Options) { const { renderer } = await options.presets.apply('core', {}, options); if (!renderer) { - console.log('getting framework name'); // At the moment some frameworks (Angular/Ember) do not define a renderer, but themselves // serve the purpose (in particular exporting the symbols needed by entrypoints) return getFrameworkName(options);