Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "ExperimentalWarning: The Fetch API is an experimental feature" shown during storybook commands in node v18 #21432

Closed
kasperpeulen opened this issue Mar 6, 2023 · 9 comments · Fixed by #21497
Assignees

Comments

@kasperpeulen
Copy link
Contributor

Describe the bug

We use isomorphic-unfetch that will use the actual fetch implementation in node 18.
However, this will cause warnings:

image

We should probably move to node-fetch, or conditionally use isomorphic-unfetch only when the environment is node 19, where the fetch impl. is stable.

To Reproduce

Start storybook v7 in node 18.

System

No response

Additional context

No response

@tmeasday
Copy link
Member

tmeasday commented Mar 9, 2023

@kasperpeulen I wasn't able to reproduce this in a sandbox:

image

Am I missing something? What node version did you use exactly?

@tmeasday tmeasday moved this from Required for GA to In Progress in Core Team Projects Mar 9, 2023
@tmeasday tmeasday self-assigned this Mar 9, 2023
@kasperpeulen
Copy link
Contributor Author

@tmeasday This only happens in node 18 and (when telemetry enabled I guess).

image

@kasperpeulen
Copy link
Contributor Author

Also happens for me in a sandbox when using node 18:

image

@github-project-automation github-project-automation bot moved this from In Progress to Done in Core Team Projects Mar 9, 2023
@tmeasday
Copy link
Member

tmeasday commented Mar 9, 2023

@kasperpeulen i was running node 18 (see screenshot) and telemetry was definitely enabled.

Which version of node 18 did you have exactly?

@tmeasday
Copy link
Member

tmeasday commented Mar 9, 2023

Oh, 18.12 I see. I'll try that version

@kasperpeulen
Copy link
Contributor Author

I can confirm that I don't see this message in next when using node 18.

@shilman
Copy link
Member

shilman commented Mar 9, 2023

Crikey!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-rc.0 containing PR #21497 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb@next upgrade --prerelease

@tmeasday
Copy link
Member

OK, I see this warning (on older versions) in node 18.12 but not 18.15. I think we should revert, we shouldn't risk making late changes to telemetry for specific minor node versions.

@tmeasday
Copy link
Member

#21526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants