-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: "ExperimentalWarning: The Fetch API is an experimental feature" shown during storybook commands in node v18 #21432
Comments
@kasperpeulen I wasn't able to reproduce this in a sandbox: Am I missing something? What node version did you use exactly? |
@tmeasday This only happens in node 18 and (when telemetry enabled I guess). |
@kasperpeulen i was running node 18 (see screenshot) and telemetry was definitely enabled. Which version of node 18 did you have exactly? |
Oh, 18.12 I see. I'll try that version |
I can confirm that I don't see this message in next when using node 18. |
Crikey!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-rc.0 containing PR #21497 that references this issue. Upgrade today to the
|
OK, I see this warning (on older versions) in node 18.12 but not 18.15. I think we should revert, we shouldn't risk making late changes to telemetry for specific minor node versions. |
Describe the bug
We use
isomorphic-unfetch
that will use the actual fetch implementation in node 18.However, this will cause warnings:
We should probably move to node-fetch, or conditionally use isomorphic-unfetch only when the environment is node 19, where the fetch impl. is stable.
To Reproduce
Start storybook v7 in node 18.
System
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: