You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's a pretty big dependency for just reading and writing to the file system in a specific directory (we don't even use it to specify the directory, we use find-cache-dir for that, which is also sort of dubious).
It includes all of ramda (lodash-like lib) because it imports it with a wildcard.
We've had some typing issues with it before, where it was distributed without the necessary sub-type packages.
The versioning/releasing is funky, as currently the versions 3.0.0-alpha.0-8 have been released after3.0.0, which doesn't make any sense. Furthermore, 3.0.0-alpha.8 is currently the version on the latest tag: https://www.npmjs.com/package/file-system-cache?activeTab=versions
Problem 2-4 could probably be fixed upstream if we wanted instead.
It provides a nice and simple get/set API around reading/writing to a directory. It might do more, but that is all we use it for, and to me it seems like something we could easily do internally without the problems listed above. As far as I can see it doesn't do anything special to improve the perf, it just uses node:fs and fs-extra under the hood.
The text was updated successfully, but these errors were encountered:
It doesn't come with type definitions because it's written in JS. This doesn't work for us, we'd either need to write a separate .d.ts file, or convert it to ts, either internally in Storybook or in the package.
All the imports from Node-natives (like os) should have the node: prefix to ensure a rouge package doesn't take over the import. 'os' -> 'node:os'
It would be preferable if the code was hosted on GitHub as that would lower the friction for contributions (and thus maintenance), but I also don't know the reasons for using a self-hosted Gitea, there could be valid reasons that I don't know about.
But it has great test coverage, which looks good.
@TheThing are you still interested in opening a PR with this, or should we attempt a migration in the core team?
file-system-cache
has some problems:find-cache-dir
for that, which is also sort of dubious).ramda
(lodash
-like lib) because it imports it with a wildcard.3.0.0-alpha.0-8
have been released after3.0.0
, which doesn't make any sense. Furthermore,3.0.0-alpha.8
is currently the version on thelatest
tag: https://www.npmjs.com/package/file-system-cache?activeTab=versionsProblem 2-4 could probably be fixed upstream if we wanted instead.
It provides a nice and simple
get
/set
API around reading/writing to a directory. It might do more, but that is all we use it for, and to me it seems like something we could easily do internally without the problems listed above. As far as I can see it doesn't do anything special to improve the perf, it just usesnode:fs
andfs-extra
under the hood.The text was updated successfully, but these errors were encountered: