Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.storybook folder is a dotfile and ignored by default by eslint #295

Closed
joscha opened this issue Jul 4, 2016 · 6 comments
Closed

.storybook folder is a dotfile and ignored by default by eslint #295

joscha opened this issue Jul 4, 2016 · 6 comments

Comments

@joscha
Copy link
Member

joscha commented Jul 4, 2016

currently config.js and webpack.config.js under ./.storybook is ignored by default by eslint. As the dotfiles option of eslint (https://github.com/eslint/eslint/blob/fca067938fcd54c98945356b41c8c9a7dc404c04/tests/lib/ignored-paths.js#L91) can't be disabled on the command line, these files never get linted.

@arunoda
Copy link
Member

arunoda commented Jul 4, 2016

Yep. May be you should change the config directory.
Check this: https://github.com/kadirahq/react-storybook/blob/master/docs/configure_storybook.md#configuration-directory

@arunoda
Copy link
Member

arunoda commented Jul 4, 2016

I'm closing this in favour of above. If you are looking for something else, reopen with more info.

@arunoda arunoda closed this as completed Jul 4, 2016
@huchenme
Copy link

can we reopen this issue? the above link does not work any more

@Hypnosphi
Copy link
Member

You can pass config directory as a CLI option:

start-storybook -c my-storybook-dir

Alternatively, you can put this line to your .eslintignore file:

!.storybook

@bsgreenb
Copy link

And don't forget to add the same line to .prettierignore if you're using that!

@LeandrodeLimaC
Copy link

If you are using a monorepo, chances are that you have to add a .eslintignore file at the root of the repository with the following content:

!.storybook

In my case, it was also necessary to add this file inside my storybook package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants